Add SkinnedNPREffect - #425
Merged
Merged
Conversation
Collaborator
Author
Chuck Walbourn (walbourn)
requested review from
Jon Martin (jonmartinms),
Nada Ouf (nadaOuf) and
Scott Matloff (scm-xbox)
July 21, 2026 18:13
Chuck Walbourn (walbourn)
marked this pull request as ready for review
July 21, 2026 18:13
Chuck Walbourn (walbourn)
marked this pull request as draft
July 21, 2026 18:28
Chuck Walbourn (walbourn)
marked this pull request as ready for review
July 24, 2026 00:07
Collaborator
Author
|
Docs for NPREffect are in place on the wiki. SkinnedNPREffect will be added when checked in. |
Nada Ouf (nadaOuf)
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends NPREffect added in Adds NPREffect to library #414 to support skinning. As with the other skinning effects, it always includes a base texture and does not support vertex coloring.
Adds NPREffectFactory for loading models using NPR.
Minor optimization for PBREffect rootsig.
CMake fix for MinGW DLL builds with 16.1.0
Make sure all effect factory classes have GetDevice method.